Review Request: Rework kdebugdialog --fullmode ui

David Faure faure at kde.org
Mon Dec 19 18:45:38 GMT 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103403/#review9093
-----------------------------------------------------------

Ship it!


Ah! OK, sorry, I mixed the proposal and the comment on the proposal.

So this patch does not merge them, it only makes fullmode more usable - no objections.

- David Faure


On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103403/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 1:15 p.m.)
> 
> 
> Review request for KDE Runtime and David Faure.
> 
> 
> Description
> -------
> 
> This patch replaces the area combobox in kdebugdialog --fullmode with a searchable tree widget.
> 
> The patch is quite large because I fixed the indentation first and converted the dialog to Designer.
> Individual commits are available in agateau/kdebugdialog-ui branch of the kde-runtime repo.
> 
> 
> Diffs
> -----
> 
>   kdebugdialog/CMakeLists.txt ed66db6 
>   kdebugdialog/kabstractdebugdialog.h 254109e 
>   kdebugdialog/kabstractdebugdialog.cpp 68d98e8 
>   kdebugdialog/kdebugdialog.h a186cfa 
>   kdebugdialog/kdebugdialog.cpp 4d01256 
>   kdebugdialog/kdebugdialog.ui PRE-CREATION 
>   kdebugdialog/klistdebugdialog.h af3ec4d 
>   kdebugdialog/klistdebugdialog.cpp 4608e7b 
>   kdebugdialog/main.cpp 13ad8dc 
> 
> Diff: http://git.reviewboard.kde.org/r/103403/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/103403/s/369/
> After
>   http://git.reviewboard.kde.org/r/103403/s/370/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111219/89d0f58b/attachment.htm>


More information about the kde-core-devel mailing list