Review Request: Make KGlobalSettings reread locale settings before calling settingsChanged().
faure at kde.org
Mon Dec 19 16:03:14 GMT 2011
On Monday 19 December 2011 15:46:14 Lamarque Vieira Souza wrote:
> > On Dec. 19, 2011, 2:35 p.m., David Faure wrote:
> > > kdeui/kernel/kglobalsettings.cpp, line 886
> > > <http://git.reviewboard.kde.org/r/103469/diff/2/?file=43867#file43867lin
> > > e886>> >
> > > I like the idea (KGlobalSettings reparsing configuration), but not
> > > the implementation (setLanguage(langage)). Can't KLocale get a
> > > reparseConfiguration() (to reuse the KConfig naming) ?
> KLocale::reparseConfiguration() would be just a call to
> KLocalePrivate::initFormat(), but initFormat is protected. I will have to
> make it public to use it in KLocale::reparseConfiguration, wouldn't that
> break binary compatibility?
Aeh? If it's called KLocalePrivate it's a private class, you can do whatever
you want with it.
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. KDE Frameworks 5
More information about the kde-core-devel