Review Request: Improvements to create_tarball so it can properly package kio_gopher

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6864/#review10581
-----------------------------------------------------------


That `mkdir #{app}` is actually a bug I did not notice. I just read and tried your patch and had no problems with it.

I would say "Ship it", but my ruby knowledge is probably more non-existent than yours ;)

- Kåre Särs


On Dec. 17, 2011, 5 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6864/
> -----------------------------------------------------------
> 
> (Updated Dec. 17, 2011, 5 p.m.)
> 
> 
> Review request for kdelibs, Release Team and Kåre Särs.
> 
> 
> Description
> -------
> 
> kio_gopher is a kioslave, thus it's docs are not in docs/extragear-network/kio_gopher but in docs/extragear-network/kioslave/gopher/
> 
> I addded a few special casing for when an addDocs entry contains a / since you need recursive mkdir and some special casing in the copy.
> 
> I could probably fold the old code with the new one, but did not want to break anything and since i ruby knowledge is totally non existent i decided to go the safe way.
> 
> Kare, i'm also adding you because i'm removing a 
> `mkdir #{app}`
> you added that i don't see why it's needed, it was basically creating an empty dir in my src dir.
> 
> 
> Diffs
> -----
> 
>   home/kde/trunk/KDE/kdesdk/scripts/createtarball/create_tarball.rb 1268943 
> 
> Diff: http://svn.reviewboard.kde.org/r/6864/diff/diff
> 
> 
> Testing
> -------
> 
> I now can build kio_gopher with the following config
> 
> [kio-gopher]
> gitModule    = yes
> mainmodule   = extragear
> submodule    = network
> kde_release  = no
> docs         = yes
> addDocs      = kioslave/gopher
> translations = yes
> version      = 0.1.4
> custompo     = kio_gopher
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111218/71e76179/attachment.htm>