Review Request: Reset time format upon user request

[Lamarque Vieira Souza]

> On Dec. 18, 2011, 8:59 a.m., David Faure wrote:
> > SETTINGS_COMPLETION !? This has nothing to do with completion. How about adding a SETTINGS_LOCALE if that's what you need?

I am trying to minimize the number of patches needed to fix bug #289094. This review is patch number two and a third patch against kdelibs will be necessary to add KGlobalSettings::SETTINGS_COMPLETION in kglobalsettings.h. As I explained in my last review I have not found any better category.


- Lamarque Vieira


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103434/#review9031
-----------------------------------------------------------


On Dec. 16, 2011, 9:13 p.m., Lamarque Vieira Souza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103434/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2011, 9:13 p.m.)
> 
> 
> Review request for kdelibs and Plasma.
> 
> 
> Description
> -------
> 
> The patch resets time format in digital clock plasmoid when the user changes the 24h configuration in active-settings.
> 
> The reset part is from kdelibs/kdecore/localization/klocale_kde.cpp. I am wondering if I should add this change to kdelibs instead of kde-workspace to avoid duplicating code. Anyway, I wanted someone to review the code to see if there can be any side effect.
> 
> 
> This addresses bug 289094.
>     http://bugs.kde.org/show_bug.cgi?id=289094
> 
> 
> Diffs
> -----
> 
>   plasma/generic/applets/digital-clock/clock.h 4aec3fd 
>   plasma/generic/applets/digital-clock/clock.cpp dd03692 
> 
> Diff: http://git.reviewboard.kde.org/r/103434/diff/diff
> 
> 
> Testing
> -------
> 
> Works in Plasma Active. In Plasma Desktop kcmlocale does not call KGlobalSettings::self()->emitChange(KGlobalSettings::SettingsChanged) so it does not take effect. Other kcm modules (e.g. keyboard), call emitChange.
> 
> 
> Thanks,
> 
> Lamarque Vieira Souza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111218/6c8ccf53/attachment.htm>
-------------- next part --------------
_______________________________________________
Plasma-devel mailing list
Plasma-devel at kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel