Review Request: Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy()

[Aaron J. Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103421/#review8997
-----------------------------------------------------------

Ship it!


other than the style issue, this looks good :)


kdeui/itemviews/kselectionproxymodel.cpp
<http://git.reviewboard.kde.org/r/103421/#comment7467>

    this should be in kdelibs style: 
    
     if (!q->sourceModel() || m_rootIndexList.isEmpty()) {
            return;
    }


- Aaron J. Seigo


On Dec. 15, 2011, 8:54 p.m., Allen Winter wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103421/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 8:54 p.m.)
> 
> 
> Review request for kdelibs and Stephen Kelly.
> 
> 
> Description
> -------
> 
> Crash guard for KSelectionProxyModelPrivate::removeRangeFromProxy()
> 
> occassionally I am encountering asserts or crashes in this method, so this little crash guard avoids those situations
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kselectionproxymodel.cpp eca2d78 
> 
> Diff: http://git.reviewboard.kde.org/r/103421/diff/diff
> 
> 
> Testing
> -------
> 
> used locally for about a week and haven't seen crashes in KSelectionProxyModel
> 
> 
> Thanks,
> 
> Allen Winter
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111216/18bf6c39/attachment.htm>