Review Request: Fix KStatusNotifierItem not updating its icon when set by pixmap

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103425/#review8990
-----------------------------------------------------------

Ship it!


good catch

- Marco Martin


On Dec. 15, 2011, 11:09 p.m., David Jarvie wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103425/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2011, 11:09 p.m.)
> 
> 
> Review request for kdelibs and Marco Martin.
> 
> 
> Description
> -------
> 
> Set the icon for KStatusNotifierItem by setIconByPixmap(), then by setIconByName(). If setIconByPixmap() is called to set the first icon again, the icon doesn't change. The same bug seems likely to happen with other pairs of icon setting methods.
> 
> This patch fixes this bug.
> 
> 
> Diffs
> -----
> 
>   kdeui/notifications/kstatusnotifieritem.cpp aecb81c 
> 
> Diff: http://git.reviewboard.kde.org/r/103425/diff/diff
> 
> 
> Testing
> -------
> 
> Tested switching setIconByPixmap()/setIconByName() in KAlarm.
> 
> 
> Thanks,
> 
> David Jarvie
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111216/ca0bf3de/attachment.htm>