Review Request: Rework kdebugdialog --fullmode ui

Aurélien Gâteau agateau at kde.org
Tue Dec 13 14:14:11 GMT 2011



> On Dec. 13, 2011, 1:45 p.m., Eike Hein wrote:
> > Could we get rid of --fullmode instead and hide away the not-always-needed stuff behind an Advanced button in normal mode? I think --fullmode is too hard to discover, I sometimes hear devs say "I wish I could log to a file" because they don't know it's there.

I agree, but it's probably not a good idea to change that for 4.8.


- Aurélien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103403/#review8917
-----------------------------------------------------------


On Dec. 13, 2011, 1:15 p.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103403/
> -----------------------------------------------------------
> 
> (Updated Dec. 13, 2011, 1:15 p.m.)
> 
> 
> Review request for KDE Runtime and David Faure.
> 
> 
> Description
> -------
> 
> This patch replaces the area combobox in kdebugdialog --fullmode with a searchable tree widget.
> 
> The patch is quite large because I fixed the indentation first and converted the dialog to Designer.
> Individual commits are available in agateau/kdebugdialog-ui branch of the kde-runtime repo.
> 
> 
> Diffs
> -----
> 
>   kdebugdialog/CMakeLists.txt ed66db6 
>   kdebugdialog/kabstractdebugdialog.h 254109e 
>   kdebugdialog/kabstractdebugdialog.cpp 68d98e8 
>   kdebugdialog/kdebugdialog.h a186cfa 
>   kdebugdialog/kdebugdialog.cpp 4d01256 
>   kdebugdialog/kdebugdialog.ui PRE-CREATION 
>   kdebugdialog/klistdebugdialog.h af3ec4d 
>   kdebugdialog/klistdebugdialog.cpp 4608e7b 
>   kdebugdialog/main.cpp 13ad8dc 
> 
> Diff: http://git.reviewboard.kde.org/r/103403/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Before
>   http://git.reviewboard.kde.org/r/103403/s/369/
> After
>   http://git.reviewboard.kde.org/r/103403/s/370/
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111213/28b729cd/attachment.htm>


More information about the kde-core-devel mailing list