Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

[Nick Shaforostoff]

> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote:
> > I have an account called shaforo. i could push to kdepimlibs with it, but i couldn't push to kdelibs. is it because  of lack of permissions?
> 
> Alexander Potashev wrote:
>     You need to clone the `kdelibs` repo from `git at git.kde.org:kdelibs.git`. Check this in `kdelibs/.git/config` on your machine.
> 
> Albert Astals Cid wrote:
>     kdelibs master is frozen because of the frameworks effort. You either commit it to the frameworks branch and wait until it's released or convince us this is a bugfix (which seems to be) and commit it to the 4.7 branch.

ok, so if nobody objects i will push it to 4.7 branch tomorrow


- Nick


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103348/#review8762
-----------------------------------------------------------


On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103348/
> -----------------------------------------------------------
> 
> (Updated Dec. 6, 2011, 5:53 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Description
> -------
> 
> pretty straightforward and small optimization of kde apps startup time:
> avoid calculating luma for the same colors multiple times.
> 
> callgrind shows it is called 4503 times
> instead of 12087 at startup of kwrite, which is 1.5%.
> 
> 
> Diffs
> -----
> 
>   kdeui/colors/kcolorutils.cpp efe8cdd 
> 
> Diff: http://git.reviewboard.kde.org/r/103348/diff/diff
> 
> 
> Testing
> -------
> 
> kwrite starts fine with the new kdeui lib
> 
> 
> Thanks,
> 
> Nick Shaforostoff
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111206/ae22162c/attachment.htm>