Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times
Alexander Potashev
aspotashev at gmail.com
Tue Dec 6 18:11:46 GMT 2011
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote:
> > I have an account called shaforo. i could push to kdepimlibs with it, but i couldn't push to kdelibs. is it because of lack of permissions?
You need to clone the `kdelibs` repo from `git at git.kde.org:kdelibs.git`. Check this in `kdelibs/.git/config` on your machine.
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103348/#review8762
-----------------------------------------------------------
On Dec. 6, 2011, 5:53 p.m., Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103348/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2011, 5:53 p.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> pretty straightforward and small optimization of kde apps startup time:
> avoid calculating luma for the same colors multiple times.
>
> callgrind shows it is called 4503 times
> instead of 12087 at startup of kwrite, which is 1.5%.
>
>
> Diffs
> -----
>
> kdeui/colors/kcolorutils.cpp efe8cdd
>
> Diff: http://git.reviewboard.kde.org/r/103348/diff/diff
>
>
> Testing
> -------
>
> kwrite starts fine with the new kdeui lib
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111206/0b06296e/attachment.htm>
More information about the kde-core-devel
mailing list