Review Request: Fix KCategorizedView race
Thomas Lübking
thomas.luebking at web.de
Mon Dec 5 14:21:11 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103335/
-----------------------------------------------------------
Review request for kdelibs, Rafael Fernández López and Jaime Torres Amate.
Description
-------
Also see https://git.reviewboard.kde.org/r/103313/
QListView::updateGeometries() has it's own opinion on whether the scrollbars should be visible (valid range) or not
and triggers a (sometimes additionally timered) resize through ::layoutChildren()
http://qt.gitorious.org/qt/qt/blobs/4.7/src/gui/itemviews/qlistview.cpp#line1499
(the comment above the main block isn't all accurate, layoutChldren is called regardless of the policy)
As a result QListView and KCategorizedView occasionally started a race on the scrollbar visibility, effectively blocking the UI
So we prevent QListView from having an own opinion on the scrollbar visibility by
fixing it before calling the baseclass QListView::updateGeometries() and restoring the policy afterwards
This addresses bugs 213068 and 287847.
http://bugs.kde.org/show_bug.cgi?id=213068
http://bugs.kde.org/show_bug.cgi?id=287847
Diffs
-----
kdeui/itemviews/kcategorizedview.cpp 46a1cde
kutils/kpluginselector.cpp ca0691d
Diff: http://git.reviewboard.kde.org/r/103335/diff/diff
Testing
-------
Yes, resizing the "kcmshell4 kwincompositing", "all effects" KPluginSelector with large scrollbar sizes (bespin/position indicator/32px; oxygen was often sufficient with the default size) after commit e91e5fed6b1aad365e12e919f430c3e8147552d3 (see https://git.reviewboard.kde.org/r/103165/ ) was a reliable way to trigger the issue for me.
It also showed that resize/updateGeometries occured in pairs (ie 4calls forming a block), what's never happened again with the patch.
Thanks,
Thomas Lübking
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111205/ce0c62fe/attachment.htm>
More information about the kde-core-devel
mailing list