Review Request: fix infinite recurssion in kcategorizedview

[Ruurd Pels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/#review8695
-----------------------------------------------------------



kdeui/itemviews/kcategorizedview.cpp
<http://git.reviewboard.kde.org/r/103313/#comment7323>

    I would say 'no halfway exit always' especially in long functions. Midfunc exit is too easily overlooked. That said, if most of processing is done in else loop if you elide the midfunc exit then the function is even more a refactoring candidate. If readability suffers... yet another reason for refactoring. 


- Ruurd Pels


On Dec. 4, 2011, 8:42 a.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103313/
> -----------------------------------------------------------
> 
> (Updated Dec. 4, 2011, 8:42 a.m.)
> 
> 
> Review request for kdelibs and Rafael Fernández López.
> 
> 
> Description
> -------
> 
> Basically, what I do is:
> If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has worked in the past, but in another file).
> Apply the same strategy with files.
> 
> Additional stuff:
> Moved the common calculus of itemSize outside of the if then else.
> 
> 
> This addresses bugs 213068 and 287847.
>     http://bugs.kde.org/show_bug.cgi?id=213068
>     http://bugs.kde.org/show_bug.cgi?id=287847
> 
> 
> Diffs
> -----
> 
>   kdeui/itemviews/kcategorizedview.cpp 46a1cde 
>   kutils/kpluginselector.cpp ca0691d 
> 
> Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
> 
> 
> Testing
> -------
> 
> Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug).
> Please, test with other programs.
> 
> 
> Thanks,
> 
> Jaime Torres Amate
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111204/af8d0f77/attachment.htm>