Review Request: fix infinite recurssion in kcategorizedview
Ruurd Pels
ruurd at tiscali.nl
Sat Dec 3 13:12:07 GMT 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103313/#review8683
-----------------------------------------------------------
Refactor it. Maybe even add a message since this might be a solution for some problem elsewhere...
kdeui/itemviews/kcategorizedview.cpp
<http://git.reviewboard.kde.org/r/103313/#comment7316>
Argh. Exit method halfway. I'd prefer reworking the trailing part of the function (refactoring a bit that is) instead of exiting halfway. Should be as easy as moving the rest of the function in the else clause AFAICS on short notice.
- Ruurd Pels
On Dec. 3, 2011, 10:55 a.m., Jaime Torres Amate wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103313/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2011, 10:55 a.m.)
>
>
> Review request for kdelibs.
>
>
> Description
> -------
>
> Basically, what I do is:
> If there are one or zero columns, hide the horizontalScrollBar until it is needed. (it has worked in the past, but in another file).
> Apply the same strategy with files.
>
> Additional stuff:
> Moved the common calculus of itemSize outside of the if then else.
>
>
> This addresses bugs 213068 and 287847.
> http://bugs.kde.org/show_bug.cgi?id=213068
> http://bugs.kde.org/show_bug.cgi?id=287847
>
>
> Diffs
> -----
>
> kdeui/itemviews/kcategorizedview.cpp 46a1cde
> kutils/kpluginselector.cpp ca0691d
>
> Diff: http://git.reviewboard.kde.org/r/103313/diff/diff
>
>
> Testing
> -------
>
> Krunner config does not loop (neither kgetnewstuff from kstars). I can not test with amarok (I've hit by an amarok start bug).
> Please, test with other programs.
>
>
> Thanks,
>
> Jaime Torres Amate
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111203/4ffdfb2e/attachment.htm>
More information about the kde-core-devel
mailing list