Review Request: Fix Date Display in dolphin info panel

Xuetian Weng wengxt at gmail.com
Thu Dec 1 10:17:38 GMT 2011



> On Dec. 1, 2011, 8:40 a.m., Sebastian Trueg wrote:
> > Ship It!

Seems I can't commit to kdelibs, could you commit this? Thank you.


- Xuetian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103300/#review8638
-----------------------------------------------------------


On Nov. 30, 2011, 9:17 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103300/
> -----------------------------------------------------------
> 
> (Updated Nov. 30, 2011, 9:17 p.m.)
> 
> 
> Review request for kdelibs and Nepomuk.
> 
> 
> Description
> -------
> 
> The date in dolphin info panel is passed by kfilemetadatareader directly. So all the localization work should be done at the kfilemetadatareader side.
> There are two problems.
> 1. date given by nepomuk is stored as UTC time, needed to convert to localtime.
> 2. date localization will not work without a KComponentData.
> 
> 
> Diffs
> -----
> 
>   nepomuk/utils/utils.cpp e81615a 
>   kio/kfile/kfilemetadatareaderprocess.cpp 03ff887 
> 
> Diff: http://git.reviewboard.kde.org/r/103300/diff/diff
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20111201/3b3f23d5/attachment.htm>


More information about the kde-core-devel mailing list