Review Request: Dolphin zoom with CTRL+MouseWheel

[Dominik Haumann]

> On Aug. 30, 2011, 4:55 p.m., Dominik Haumann wrote:
> > dolphin/src/views/dolphinview.cpp, line 691
> > <http://git.reviewboard.kde.org/r/102490/diff/1/?file=33274#file33274line691>
> >
> >     Just a maybe:
> >     if event->delta() is < 8, numDegrees rounds to 0 due to the int conversion. Same for numSteps. I'm not sure whether this can happen, but I remember a similar issue somewhere else (was it in Kate?)...
> 
> Peter Penz wrote:
>     Thanks for the hint, I've added this to my TODO-list - hope I find some time to check this before the 2.0 release of Dolphin (still there are so many things that must be fixed first ;-))

Funnily, the patch works exactly as in the Qt documentation suggested: http://doc.qt.nokia.com/latest/qwheelevent.html#delta
So maybe it's completely fine this way.


- Dominik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102490/#review6174
-----------------------------------------------------------


On Aug. 30, 2011, 11:08 a.m., Vishesh Yadav wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102490/
> -----------------------------------------------------------
> 
> (Updated Aug. 30, 2011, 11:08 a.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> Zoom DolphinView when mouse wheel is scrolled with CRTL button pressed.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d 
>   dolphin/src/views/dolphinview.h 7c81ea8 
>   dolphin/src/views/dolphinview.cpp 0991401 
> 
> Diff: http://git.reviewboard.kde.org/r/102490/diff
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Vishesh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110830/62e17097/attachment.htm>