Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

[Peter Penz]

> On Aug. 29, 2011, 9:40 a.m., Peter Penz wrote:
> > Thanks for the update! Looks good and is exactly like the proposal you, Frank and I discussed per e-mail. As usual I've added a punch of my nitpicking stuff ;-) Please push it to master after fixing, you don't need to add another diff here.
> 
> Tirtha Chatterjee wrote:
>     I have used itemActivated signal here since itemTriggered is already used by DolphinView. Then I noticed that in my previous keyboard-searching patch, we use the name 'activation' to mean selection. So is it okay to use activation here?

QAbstractItemView also uses the signal 'activated()' for the same meaning as we have, so I'd say using itemActivated() instead of itemTriggered() is fine. Would like to hear Frank's opinion about this, but I'd say please push the patch, we can change this afterwards if we change our mind (currently I'd also tend to rename the DolphinView signal to 'itemActivated' for consistency).


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102450/#review6128
-----------------------------------------------------------


On Aug. 29, 2011, 9:14 a.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102450/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2011, 9:14 a.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c 
>   dolphin/src/views/dolphinview.h 437f12f 
>   dolphin/src/views/dolphinview.cpp 959e4da 
> 
> Diff: http://git.reviewboard.kde.org/r/102450/diff
> 
> 
> Testing
> -------
> 
> Yes, tested and working.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110829/19c0c392/attachment.htm>