Review Request: Allow opening files and directories by pressing 'Enter' or 'Return'

Peter Penz peter.penz19 at gmail.com
Mon Aug 29 05:50:27 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102450/#review6114
-----------------------------------------------------------


Thanks, but you need please to rebase your diff against master first (see e.g. plasma/applets/folderview/plasma-applet-folderview.desktop and other files that have already been committed)

- Peter


On Aug. 28, 2011, 11:33 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102450/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2011, 11:33 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> Allow opening files and directories by pressing 'Enter' key. In case multiple files are selected when enter is pressed, all of them are opened. In case of multiple directories, the first directory gets opened in the current tab, while the other directories open in new tabs.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt b443aa7 
>   dolphin/src/kitemviews/kfileitemmodel.h 0fecbcf 
>   dolphin/src/kitemviews/kfileitemmodel.cpp c2f49f7 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 0d2637d 
>   dolphin/src/kitemviews/kitemlistcontroller.h 04d4985 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 207535c 
>   dolphin/src/kitemviews/kitemlistkeyboardsearchmanager.cpp 34633d6 
>   dolphin/src/kitemviews/kitemlistkeyboardsearchmanager_p.h cf41f3b 
>   dolphin/src/kitemviews/kitemlistview.h 9977e36 
>   dolphin/src/kitemviews/kitemlistview.cpp a35752a 
>   dolphin/src/kitemviews/kitemmodelbase.h c4e0464 
>   dolphin/src/kitemviews/kitemmodelbase.cpp 69f62bc 
>   dolphin/src/views/dolphinview.h 437f12f 
>   dolphin/src/views/dolphinview.cpp 959e4da 
>   plasma/applets/folderview/plasma-applet-folderview.desktop 03fbfff 
> 
> Diff: http://git.reviewboard.kde.org/r/102450/diff
> 
> 
> Testing
> -------
> 
> Yes, tested and working.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110829/453777a4/attachment.htm>


More information about the kde-core-devel mailing list