Review Request: Make Dolphin honour the KGlobalSettings::singleClick option.

[Peter Penz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102447/#review6042
-----------------------------------------------------------



dolphin/src/kitemviews/kitemlistcontroller.cpp
<http://git.reviewboard.kde.org/r/102447/#comment5320>

    Should be:
        bool emitItemClicked = KGlobalSettings::singleClick() || (event->button() != Qt::LeftButton);
    
    otherwise opening a context-menu does not work anymore in the doubleclick mode (or middleclicking is not possible).



dolphin/src/kitemviews/kitemlistcontroller.cpp
<http://git.reviewboard.kde.org/r/102447/#comment5321>

    Should be something like:
    
        const bool useDoubleClick = !KGlobalSettings::singleClick() &&
                                    (event->buttons() & Qt::LeftButton) &&
                                    index >= 0 && index < m_model->count();
        if (useDoubleClick) {
    
    to work correctly with the change done above.


Thanks, works nice! Please push it to master after fixing the two minor issues above.

- Peter


On Aug. 26, 2011, 8:51 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102447/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 8:51 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> Honours the KGlobalSettings::singleClick() setting (set from Mouse KCM, whether files should be opened on single or double clicks), and functions accordingly.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontroller.cpp 29e2f47 
> 
> Diff: http://git.reviewboard.kde.org/r/102447/diff
> 
> 
> Testing
> -------
> 
> Yes tested and works.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110827/e277e755/attachment.htm>