Review Request: Allow externally deleted files to be removed from view in Dolphin

Peter Penz peter.penz19 at gmail.com
Fri Aug 26 07:11:14 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102435/#review6020
-----------------------------------------------------------

Ship it!


Thanks for the patch, works nice! I've added a small unit-test for it and have just pushed it to master.

- Peter


On Aug. 25, 2011, 7:23 p.m., Tirtha Chatterjee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102435/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2011, 7:23 p.m.)
> 
> 
> Review request for KDE Base Apps and Peter Penz.
> 
> 
> Summary
> -------
> 
> Currently, if a file is deleted by an external application, and the directory containing that file is open in Dolphin, the change is not reflected in Dolphin until we refresh. This patch fixes it.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 189aa75 
> 
> Diff: http://git.reviewboard.kde.org/r/102435/diff
> 
> 
> Testing
> -------
> 
> Yes, tested locally.
> 
> 
> Thanks,
> 
> Tirtha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110826/3314db9e/attachment.htm>


More information about the kde-core-devel mailing list