Review Request: Fix for kio_sftp login problems

Dawit Alemayehu adawit at kde.org
Thu Aug 25 05:41:28 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102428/
-----------------------------------------------------------

Review request for KDE Runtime and Andreas Schneider.


Summary
-------

The attached patch should address the login problems in kio_sftp caused by the recent changes that enable kio_sftp to work correctly when the original user name is changed from within the password dialog. That is, if the original url was sftp://foo@foohost.bar, then changing "foo" to something else in the password dialog box should do the correct thing and update the client application about the change.


Diffs
-----

  kioslave/sftp/kio_sftp.h 7cd16d1 
  kioslave/sftp/kio_sftp.cpp eb5c8a8 

Diff: http://git.reviewboard.kde.org/r/102428/diff


Testing
-------

Login without a user name in the url, e.g. sftp://127.0.0.1.
Login using the correct user name in the url, e.g. sftp://foo@127.0.0.1.
Login with an incorrect user-name and changing it in the password dialog.
Browsing the directory after logging in using the above step.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110825/78feab58/attachment.htm>


More information about the kde-core-devel mailing list