Review Request: Fixed rating in knewstupp3.

[Jeremy Paul Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102416/#review5953
-----------------------------------------------------------

Ship it!


Looks good.  If you have commit access, go for it, otherwise let us know and I can.

- Jeremy Paul


On Aug. 23, 2011, 4:32 p.m., Oldřich Jedlička wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102416/
> -----------------------------------------------------------
> 
> (Updated Aug. 23, 2011, 4:32 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The slot disconnection uses wrong call, so the slot is actually never disconnected and the voting could be sent several times. Also limit the rating for the rating widget to be in expected range 0-10.
> 
> 
> This addresses bug 261530.
>     http://bugs.kde.org/show_bug.cgi?id=261530
> 
> 
> Diffs
> -----
> 
>   knewstuff/knewstuff3/ui/entrydetailsdialog.cpp 2bf0e943c13ee0a4182c5c80d7f5f0d2697fdc91 
> 
> Diff: http://git.reviewboard.kde.org/r/102416/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Oldřich
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110823/7315f111/attachment.htm>