Review Request: Handle focus in KUrlNavigator

[Peter Penz]

> On Aug. 20, 2011, 3 p.m., Commit Hook wrote:
> > This review has been submitted with commit ae3b7a48ec0e34ac64c5531ec45b1f898594898a by Peter Penz to branch KDE/4.7.

Thanks for the update of the patch, it works nice now! I did some minor modifications (the button should not trigger the parent to repaint() itself etc.) but pushed your patch to "KDE/4.7" and the "frameworks" branch.


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102345/#review5855
-----------------------------------------------------------


On Aug. 18, 2011, 6 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102345/
> -----------------------------------------------------------
> 
> (Updated Aug. 18, 2011, 6 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch makes KUrlNavigator focusable.
> Also, QStyle::drawControl is used instead of QPainter::drawText in KUrlNavigatorButton, because accelerators are set in the buttons and drawText did not display them correctly.
> 
> 
> Diffs
> -----
> 
>   kfile/kurlnavigator.cpp e71c979 
>   kfile/kurlnavigatorbutton.cpp 5d38e56 
>   kfile/kurlnavigatorbutton_p.h 20ce117 
>   kfile/kurlnavigatorbuttonbase.cpp 45f8eee 
>   kfile/kurlnavigatorbuttonbase_p.h 70aacb3 
> 
> Diff: http://git.reviewboard.kde.org/r/102345/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110820/14d03a29/attachment.htm>