Review Request: Remove QObject::connect warning

Frederik Gladhorn gladhorn at kde.org
Wed Aug 17 10:04:50 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102258/#review5763
-----------------------------------------------------------

Ship it!


Thanks! Looks good to me.

- Frederik


On Aug. 8, 2011, 9:01 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102258/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2011, 9:01 p.m.)
> 
> 
> Review request for kdelibs and Frederik Gladhorn.
> 
> 
> Summary
> -------
> 
> The pushbutton does not have a triggered(QAction*) signal, so remove both the connect and the slot connected to it
> 
> 
> Diffs
> -----
> 
>   knewstuff/knewstuff3/ui/entrydetailsdialog.h f636976 
>   knewstuff/knewstuff3/ui/entrydetailsdialog.cpp 2bf0e94 
> 
> Diff: http://git.reviewboard.kde.org/r/102258/diff
> 
> 
> Testing
> -------
> 
> None
> 
> 
> Thanks,
> 
> Albert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110817/846f32b0/attachment.htm>


More information about the kde-core-devel mailing list