Review Request: Avoid terminating the thread in kio/kio/hostinfo.cpp
Dawit Alemayehu
adawit at kde.org
Mon Aug 15 06:20:52 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102238/
-----------------------------------------------------------
(Updated Aug. 15, 2011, 5:20 a.m.)
Review request for kdelibs.
Changes
-------
Removed dead code that causes lookupHost to fail almost every time.
Summary
-------
The attached patch is an alternate approach to address the issue of crashes that arise from terminating an active thread than the one proposed at https://git.reviewboard.kde.org/r/102179/. With this patch the function "QHostInfo::lookupHost(QString, int)" avoids the use of QThread::terminate with the following fairly simple changes:
- Connect its finished signal to its parent deleteLater slot in the ctor so that the thread is automatically deleted later.
- Store the looked up DNS info in the global cache to avoid unnecessary queries for the same request.
- Check for cached DNS information and avoid doing reverse look ups before resorting to performing DNS queries in a separate thread.
Diffs (updated)
-----
kio/kio/hostinfo.cpp 344b1d8
Diff: http://git.reviewboard.kde.org/r/102238/diff
Testing
-------
Local unit testing code. Tested both failing and working DNS lookup scenarios.
Thanks,
Dawit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110815/1f02ffdc/attachment.htm>
More information about the kde-core-devel
mailing list