Review Request: Dolphin's preview configuration doesn't support over 2 GB files.

Peter Penz peter.penz19 at gmail.com
Sun Aug 14 11:31:14 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102319/#review5683
-----------------------------------------------------------

Ship it!


Thanks for the patch, looks fine! Please push it to master (if you don't have a git-account please let me know and I'll push it for you)

- Peter


On Aug. 13, 2011, 10:03 p.m., Jussi Judin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102319/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2011, 10:03 p.m.)
> 
> 
> Review request for KDE Base Apps.
> 
> 
> Summary
> -------
> 
> Fix Dolphin's preview settings to support larger preview sizes than 2 GB in size. Reported as KDE bug 280034.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/general/previewssettingspage.cpp 590a51d 
> 
> Diff: http://git.reviewboard.kde.org/r/102319/diff
> 
> 
> Testing
> -------
> 
> Steps to Reproduce:
> Input 9999 megabytes to maximum preview size and save configuration. Then close configuration and go to the preview settings again and notice that the maximum preview size is not 9999 megabytes.
> 
> Expected Results:  
> Maximum preview size should be the one entered in the input box after saving Dolphin's configuration.
> 
> 
> Thanks,
> 
> Jussi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110814/3b14deb8/attachment.htm>


More information about the kde-core-devel mailing list