Review Request: Do not terminate threads

Albert Astals Cid tsdgeos at
Thu Aug 11 23:10:35 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated Aug. 11, 2011, 10:10 p.m.)

Review request for kdelibs and Dawit Alemayehu.


Rename Petition to Request
Use QMap::insert instead of [] =


Each time the terminate code triggers my Konqueror crashes, i'm substituting the terminate for just waiting the thread to finish and we just ignoring it.

The code has a race condition in which wait() returns false, then we switch to the thread and m_autoDelete is still not set and thus noone will delete the thread. I can add a mutex if you guys think this is unacceptable.

Diffs (updated)

  kio/kio/hostinfo.cpp 344b1d8 



When the 
kDebug() << "Name look up for" << hostName << "failed";
if triggers i do not get a crash anymore.



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list