Review Request: Make KSambaSharePrivate::getNetUserShareInfo less noisy

David Faure faure at kde.org
Thu Aug 11 11:06:18 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102172/#review5627
-----------------------------------------------------------

Ship it!


Sure, nice addition to my initial ac7fe47dc commit.

- David


On Aug. 1, 2011, 10:52 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102172/
> -----------------------------------------------------------
> 
> (Updated Aug. 1, 2011, 10:52 p.m.)
> 
> 
> Review request for kdelibs and Rodrigo Belem.
> 
> 
> Summary
> -------
> 
> Each time I open a open dialog i get a complain from KSambaSharePrivate::getNetUserShareInfo that says
> kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: We got some errors while running 'net usershare info' 
> kolourpaint(25821) KSambaSharePrivate::getNetUserShareInfo: "net usershare: usershares are currently disabled"
> With this patch people like me that have never configured that stop receiving the noise on the shell
> 
> 
> Diffs
> -----
> 
>   kio/kio/ksambashare.cpp cd878b6 
> 
> Diff: http://git.reviewboard.kde.org/r/102172/diff
> 
> 
> Testing
> -------
> 
> The noise is gone
> 
> 
> Thanks,
> 
> Albert
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110811/9dc33b57/attachment.htm>


More information about the kde-core-devel mailing list