Fix kopete/kdenetwork build against Qt 4.8

David Faure faure at kde.org
Thu Aug 11 10:47:18 BST 2011


On Thursday 04 August 2011 07:46:57 Jeremy Whiting wrote:
> Hello,
> 
> Qt 4.8 has a change to moc which makes virtual inheritance from QObject no
> longer possible.  This caused a problem in Jovie that was fixed by not
> virtually inheriting from QObject anymore.  There is a similar compile
> problem in kdenetwork/kopete/libkopete at the moment and the attached patch
> fixes the problem.  I can commit to 4.7 and trunk if it looks good to
> others.

Looks definitely good. Virtual inheritance has only given us trouble, with 
things like qobjects. +1 for getting rid of 'virtual' there.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).





More information about the kde-core-devel mailing list