Review Request: Prevent KMessageBox instances with a parent from being application modal

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/
-----------------------------------------------------------

(Updated Aug. 9, 2011, 8:39 a.m.)


Review request for kdelibs.


Changes
-------

The patch has been revised to use the Options parameter to specify window-modal instead, as suggested by Thomas.


Summary
-------

According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal. This patch fixes this.


Diffs (updated)
-----

  kdeui/dialogs/kmessagebox.cpp 939be89 
  kdeui/dialogs/kmessagebox.h 286880e 

Diff: http://git.reviewboard.kde.org/r/102246/diff


Testing
-------

Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets in a different window tree were still able to be used.

kmessageboxtest runs ok.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110809/33ecd86e/attachment.htm>