Review Request: Replace thread usage with local event loop in kio/kio/hostinfo.cpp

Thiago Macieira thiago at
Mon Aug 8 16:25:10 BST 2011

On Monday, 8 de August de 2011 14:25:13 David Faure wrote:
> And since I just fixed the crash (missing wait() after terminate(), see
> commit log), I don't think we need this change. However reusing threads
> might be a good idea (separate issue).

This could probably use a redesign. If this class only handles requests coming 
from the ioslave, why does it need to be blocking? Can't it be non-blocking 
and send the result back later?

Thiago Macieira - thiago (AT) - thiago (AT)
   Software Architect - Intel Open Source Technology Center
      PGP/GPG: 0x6EF45358; fingerprint:
      E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 190 bytes
Desc: This is a digitally signed message part.
URL: <>

More information about the kde-core-devel mailing list