Review Request: Prevent KMessageBox instances with a parent from being application modal

David Jarvie djarvie at kde.org
Sun Aug 7 16:18:38 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102246/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

According to the apidocs, KMessageBox instances with a parent widget specified are supposed to be window modal, not application modal. This patch fixes this.


Diffs
-----

  kdeui/dialogs/kmessagebox.cpp 939be89 

Diff: http://git.reviewboard.kde.org/r/102246/diff


Testing
-------

Tested warningYesNo(), questionYesNoCancel() with a parent widget - widgets in a different window tree were still able to be used.

kmessageboxtest runs ok.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110807/c5850271/attachment.htm>


More information about the kde-core-devel mailing list