Review Request: Pass KAboutData::productName() to DrKonqi
Christoph Feck
christoph at maxiom.de
Sat Aug 6 00:24:32 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102231/
-----------------------------------------------------------
Review request for KDE Runtime, kdelibs, George Kiagiadakis, and Darío Andrés Rodríguez.
Summary
-------
Some applications, such as muon and Calligra apps, specify a bugzilla product/component via the KAboutData::setProductName() call. This works fine for bug reports via the "Report Bug..." menu, but fails for crashes. These currently go to "kde/general" when the product is not found.
This patch adds a "--productname" parameter to the internal DrKonqi invokation call from the KDE default crash handler, and it is expected that DrKonqi developers decide if they add this feature in DrKonqi. It should handle both pure product names (such as "muon"), as well as product/component combinations (e.g. "muon/installer").
Diffs
-----
kdecore/kernel/kaboutdata.h 16861f4
kdecore/kernel/kaboutdata.cpp e49bddb
kdeui/util/kcrash.cpp b7abece
Diff: http://git.reviewboard.kde.org/r/102231/diff
Testing
-------
I forced a crash via Q_ASSERT in a test application, and the "--productname" parameter got added when it was specified via setProductName(). DrKonqi failed to handle it, though, it aborted with "drkonqi: Unknown option 'productname'."
Thanks,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110805/5530c1d5/attachment.htm>
More information about the kde-core-devel
mailing list