Review Request: new kded daemon to check .thumbnail directory space usage

Christoph Feck christoph at maxiom.de
Thu Aug 4 13:14:44 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102083/#review5389
-----------------------------------------------------------


> it is missing the code to delete the files

And I doubt we will be able to solve this.
* Delete thumbnails of files that are no longer present? I have thumbnails from files of external hard disks, and I rather would like to keep them when unmounting those disks.
* Delete thumbnails of files that are accessed long ago? My file systems are mounted in a way to not track read accesses, so it cannot know if a file has been recently used.

Instead of constantly deleting the wrong files, you could rather fire Sweeper and delete all of them. Being notified about the space issue is an improvement, though.

What I rather would like to see:
* Being able to manually browse/delete thumbnails by path: A thumbnail:// kioslave basically, that keeps the folder hierarchy.
* Integration with Nepomuk, so that thumbnails automatically get moved/deleted when the original file is.

Yes, this means not to use (or do a complete overhaul of) the thumbnail specs.

- Christoph


On July 25, 2011, 1:58 p.m., Jaime Torres Amate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102083/
> -----------------------------------------------------------
> 
> (Updated July 25, 2011, 1:58 p.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is not yet complete, it is missing the code to delete the files, trailing spaces and comments in spanish. (coming in next patch version)
> 
> There are also some things I'm not sure how should be done...
> The translations in .notifyrc and .desktop files, should be removed or just keep the lines with an empty traslation?
> Classes names, method names and variable names are OK?
> 
> 
> This addresses bug 79943.
>     http://bugs.kde.org/show_bug.cgi?id=79943
> 
> 
> Diffs
> -----
> 
>   directoryusagenotifier/module.cpp PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier_prefs_base.ui PRE-CREATION 
>   directoryusagenotifier/module.h PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier.notifyrc PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier.desktop PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier.kcfg PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier.cpp PRE-CREATION 
>   directoryusagenotifier/Messages.sh PRE-CREATION 
>   directoryusagenotifier/README PRE-CREATION 
>   directoryusagenotifier/cleanupdirectory.h PRE-CREATION 
>   directoryusagenotifier/cleanupdirectory.cpp PRE-CREATION 
>   directoryusagenotifier/directoryusagenotifier.h PRE-CREATION 
>   directoryusagenotifier/CMakeLists.txt PRE-CREATION 
>   directoryusagenotifier/COPYING PRE-CREATION 
>   CMakeLists.txt 89d97cd 
>   directoryusagenotifier/settings.kcfgc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102083/diff
> 
> 
> Testing
> -------
> 
> It works as expected (except it does not yet clean the directory).
> 
> 
> Thanks,
> 
> Jaime Torres
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110804/e8fe03b6/attachment.htm>


More information about the kde-core-devel mailing list