Review Request: Remove KGlobal::locale warning for pure Qt applications

Albert Astals Cid tsdgeos at terra.es
Tue Aug 2 21:42:24 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102188/
-----------------------------------------------------------

Review request for kdelibs and David Faure.


Summary
-------

Pure Qt applications get KDE dialogs through the various KFileDialogQtOverride members, these functions instantiate a KFileDialog that inherits from KDialog so on KFileDialog construction we end up in KDialogPrivate::init that calls KDialog::setButtons that uses KStandardGuiItem::ok() that has a i18n call. Since there is no valid main component at this stage yet once we get to the fileModule() call and it creates a proper main component we will get the KGlobal::locale warning.

By invoking fileModule() before creating the KFileDialog we avoid this issue.


Diffs
-----

  kio/kfile/kfiledialog.cpp 4195a68 

Diff: http://git.reviewboard.kde.org/r/102188/diff


Testing
-------

Warning is gone


Thanks,

Albert

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110802/acc7dea6/attachment.htm>


More information about the kde-core-devel mailing list