Review Request: PATCH: Fix most of the login issues with the FTP ioslave...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101173/
-----------------------------------------------------------

(Updated April 27, 2011, 9:27 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Removed the m_bUserNameChanged flag and replaced it with a parameter in ftpLogin.


Summary
-------

The attached patch addresses most of the FTP login related problems and is a replacement for the previous review request
https://git.reviewboard.kde.org/r/100873/. Here are all the changes in this patch:

- Show the "Remember password" checkbox even after the failure of the first login attempt. [Bug:258888]
- Always check for cached password before trying to login anonymously unless the "TryAnonymousLoginFirst"
  flag was set in kio_ftprc. [Bug: 99686, 143488, 124675]
- Avoid sending the "anonymous" username so it will not be used in the key used to store the password in kwallet.
- When a url contains a username, but the user chooses to login with a different username in the password dialog, 
  then use redirection to update the client of the change.
- Store password information in persistent storage if and only if the user checked the "Remember password" checkbox.


This addresses bugs 99686, 124675, 143488, and 258888.
    http://bugs.kde.org/show_bug.cgi?id=99686
    http://bugs.kde.org/show_bug.cgi?id=124675
    http://bugs.kde.org/show_bug.cgi?id=143488
    http://bugs.kde.org/show_bug.cgi?id=258888


Diffs (updated)
-----

  kioslave/ftp/ftp.h 4ccdd4c 
  kioslave/ftp/ftp.cpp f7db42b 

Diff: http://git.reviewboard.kde.org/r/101173/diff


Testing
-------

- Attempt to login with incorrect username and validate the "Remember password" is actually shown again.
- Corrected the username information from the password dialog to ensure the client is updated properly about the password change.
- Clicked on the "Remember password" to store password in persistent storage and retry logging into the same server at a later point.


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110427/4fd991ac/attachment.htm>