Review Request: First part of fixes for password caching in KIO: SlaveBase::openPaswordDialog

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101174/
-----------------------------------------------------------

(Updated April 24, 2011, 12:10 a.m.)


Review request for kdelibs and David Faure.


Summary (updated)
-------

The is the first part of a two part patch set that changes the current behavior of openPasswordDialog such that it will not automatically store the password even when the user checks the "Remember password" checkbox. The reason behind this change is to make sure incorrect or invalid password information is not stored in the wallet. And that can only be achieved if the ioslaves first have to verify the password information is valid by using it to gain access to the password protected server.


Diffs
-----

  kio/kio/slavebase.h f8ee99a 
  kio/kio/slavebase.cpp 6432edb 

Diff: http://git.reviewboard.kde.org/r/101174/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110424/5a1a2a81/attachment.htm>