Review Request: PATCH: Prevent SlaveBase::openPasswordDialog from automatically storing password information

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101174/
-----------------------------------------------------------

(Updated April 23, 2011, 2:43 p.m.)


Review request for kdelibs.


Changes
-------

Updated API documentation
Changed the name of the AuthInfo extra field property to "skip-caching-on-query"


Summary
-------

The attached patch changes the current behavior of openPasswordDialog such that it will not automatically store the password if the user checked the "Remember password" checkbox. This prevents the problem of storing the password information before the ioslaves had a chance to test whether or not the credentials can be used to successfully authentication against the server. IOW, it avoid the storage of invalid or incorrect password information.


Diffs (updated)
-----

  kio/kio/slavebase.h f8ee99a 
  kio/kio/slavebase.cpp 6432edb 

Diff: http://git.reviewboard.kde.org/r/101174/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110423/f96d8d9d/attachment.htm>