Review Request: Show "Version Fixed In" if available, for reports marked as FIXED

George Kiagiadakis kiagiadakis.george at gmail.com
Sat Apr 23 14:16:55 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101200/#review2850
-----------------------------------------------------------

Ship it!


Hi Dario,
Thanks for the patches.

Here, I think the strings should say "fixed ... in version %1" rather than "fixed ... in %1". Other than that, it looks fine.

- George


On April 23, 2011, 12:27 p.m., Darío Andrés Rodríguez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101200/
> -----------------------------------------------------------
> 
> (Updated April 23, 2011, 12:27 p.m.)
> 
> 
> Review request for KDE Runtime and George Kiagiadakis.
> 
> 
> Summary
> -------
> 
> Use the "Version Fixed In" bugzilla field if it is available
> 
> 
> Diffs
> -----
> 
>   drkonqi/reportassistantpages_bugzilla_duplicates.cpp a8a7fd0 
> 
> Diff: http://git.reviewboard.kde.org/r/101200/diff
> 
> 
> Testing
> -------
> 
> The version fixed in is shown, however, due to some bugzilla limitation the version numbers lack the dots (ex. "4.7.0" is shown as "4 7 0").
> 
> 
> Thanks,
> 
> Darío Andrés
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110423/05dc1b12/attachment.htm>


More information about the kde-core-devel mailing list