Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

Dawit Alemayehu adawit at
Mon Apr 18 23:29:05 BST 2011

This is an automatically generated e-mail. To reply, visit:

(Updated April 18, 2011, 10:29 p.m.)

Review request for kdelibs and David Faure.


Fixed one more issue with the patch as pointed out by david...


The attached patch changes the ftpGet function such that it emits the mime-type of the content it is about to read, before starting to read it. That way kio_ftp will work correctly if and when it is put on hold to be reused from another application. Note that the patch uses QIODevice::peek to achieve this goal.

Diffs (updated)

  kioslave/ftp/ftp.h 9814c10 
  kioslave/ftp/ftp.cpp 64f43d8 





-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list