Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101149/
-----------------------------------------------------------

(Updated April 18, 2011, 7:39 p.m.)


Review request for kdelibs and David Faure.


Changes
-------

Updated patch based on feedback. The code that emits mime-type tries its best to use 1024 bytes if available.


Summary
-------

The attached patch changes the ftpGet function such that it emits the mime-type of the content it is about to read, before starting to read it. That way kio_ftp will work correctly if and when it is put on hold to be reused from another application. Note that the patch uses QIODevice::peek to achieve this goal.


Diffs (updated)
-----

  kioslave/ftp/ftp.h 9814c10 
  kioslave/ftp/ftp.cpp 64f43d8 

Diff: http://git.reviewboard.kde.org/r/101149/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110418/34fac55f/attachment.htm>