Review Request: [PATCH] Make the FTP ioslave emit mime-type of the content before actually reading it
Dawit Alemayehu
adawit at kde.org
Mon Apr 18 03:12:21 BST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101149/
-----------------------------------------------------------
Review request for kdelibs and David Faure.
Summary
-------
The attached patch changes the ftpGet function such that it emits the mime-type of the content it is about to read, before starting to read it. That way kio_ftp will work correctly if and when it is put on hold to be reused from another application. Note that the patch uses QIODevice::peek to achieve this goal.
Diffs
-----
kioslave/ftp/ftp.cpp 64f43d8
Diff: http://git.reviewboard.kde.org/r/101149/diff
Testing
-------
Thanks,
Dawit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110418/e9f2844e/attachment.htm>
More information about the kde-core-devel
mailing list