Review Request: GUI configuration for the 'Do Not Track' feature...

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101124/
-----------------------------------------------------------

(Updated April 17, 2011, 4:22 p.m.)


Review request for kdelibs.


Changes
-------

- Changed the implementation such that:
   * DNT:0 is never ever sent to the server since no header supposedly implies OPT-IN
      by default according to the spec listed in the description section.
   * By default the DNT:1 header to OPT-OUT is not sent. The user would have to explicitly
      enable this functionality just like in Firefox 4.
- Updated label to make it clear that we are only sending a header. See new screenshot.


Summary
-------

The attach patch adds GUI configuration for the 'Do Not Track' feature that has just been implemented in kio_http[1]. Support for the Do Not Track functionality exists in almost all of the recent versions of the major browsers. The draft spec for this feature can be found at http://www.ietf.org/id/draft-mayer-do-not-track-00.txt. 

[1] http://commits.kde.org/kdelibs/6c0da96a5735ca3517350791bf7b49f558837553

Anyhow, the patch also includes cleanup of the code in htmlopts.cpp. Any objections, insights, suggestions are all welcome before I commit this.


Diffs (updated)
-----

  konqueror/settings/konqhtml/htmlopts.h b0faf0d 
  konqueror/settings/konqhtml/htmlopts.cpp 1ca17cb 

Diff: http://git.reviewboard.kde.org/r/101124/diff


Testing
-------


Screenshots (updated)
-----------

screenshot
  http://git.reviewboard.kde.org/r/101124/s/130/


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110417/5cc0ba91/attachment.htm>