Review Request: Set the properties action fom mainWindow actionCollection

Alex Fiestas alex at eyeos.org
Sun Apr 10 10:54:41 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101076/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

In order to have a proper kiosk support in dolphin we should use standard actions whether we can. Dolphin does it right but a few exceptions, this try to fix one of those.

the properties action from items is made by getting it from the mainWindow::actionCollection but the "properties" action from openViewportContextMenu is custom, which bypasses kiosk.

The patch simply replace the custom properties action and uses the mainWindow::actionCollection one.


Diffs
-----

  dolphin/src/dolphincontextmenu.cpp 0aa82b2 

Diff: http://git.reviewboard.kde.org/r/101076/diff


Testing
-------

Compare the result of clicking on the Properties custom action and the standard one.


Thanks,

Alex

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110410/04641990/attachment.htm>


More information about the kde-core-devel mailing list