Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager & KIO::Scheduler

[Dawit Alemayehu]

> On April 6, 2011, 10:17 p.m., David Faure wrote:
> > Thanks for working on this, iirc this is needed by many users.

You are welcome. Yes, a lot of users that rely on PAC files (in corporate settings) have asked for these functionality for a very long time (back to the good old KDE 2.x days). Since no one did anything about it, I decided it is only fitting for me to actually finish what I started a long long time ago.

BTW, there is still part III and IV of these fixes remaining. Part III is to modify the ioslaves to use multiple proxies as necessary and the last part would be the UI stuff which needs to be simplified and cleaned up a great deal.


> On April 6, 2011, 10:17 p.m., David Faure wrote:
> > kio/kio/kprotocolmanager.cpp, line 299
> > <http://git.reviewboard.kde.org/r/101037/diff/1/?file=13846#file13846line299>
> >
> >     s/any/if any/


> On April 6, 2011, 10:17 p.m., David Faure wrote:
> > kio/kio/kprotocolmanager.h, line 249
> > <http://git.reviewboard.kde.org/r/101037/diff/1/?file=13845#file13845line249>
> >
> >     Shouldn't this return only one proxy server address, as it did before? Otherwise existing code could get broken by this change, I fear.
> >     You added a separate method for getting a stringlist anyway.

Only the documentation is wrong. The function behaves exactly as before. Will revert the unintentional documentation change back.


- Dawit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101037/#review2447
-----------------------------------------------------------


On April 6, 2011, 4:31 a.m., Dawit Alemayehu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101037/
> -----------------------------------------------------------
> 
> (Updated April 6, 2011, 4:31 a.m.)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This the second part of a series of patches designed to improve and bring KIO's proxy support to the levels of KDE 3.5 and beyond. Unlike the first series, https://git.reviewboard.kde.org/r/100971/, these set of patches are focused on the two classes in KIO that are responsible for providing proxy information to all ioslaves, KProtocolManager and KIO::Scheduler. Here are a list of the changes contained within:
> 
> KProtocolManager:
> ------------------
> * Add socks proxy support to KProtocolManager.
> * Add functions for obtaining multiple proxy URL addresses when configured through PAC scripts.
> * Add support for obtaining system proxy information on Windows and Mac platforms. [1]
> 
> KIO::Scheduler:
> ---------------
> * Set a new meta-data, "ProxyUrls" with a list of comma separated proxy urls.[2]
> 
> 
> [1] Please note that on Linux/Unix platforms system proxy configuration is assumed to be set through enivronment variables and has been supported since the days of KDE 2.0.
> [2] The existing meta-data "UseProxy" will still be set with the first url from the list.
> 
> 
> Diffs
> -----
> 
>   kio/kio/scheduler.cpp d657bf6 
>   kio/DESIGN.metadata f5dfcd1 
>   kio/kio/job_p.h 620e487 
>   kio/kio/kprotocolmanager.h 814e2f2 
>   kio/kio/kprotocolmanager.cpp 56e1942 
> 
> Diff: http://git.reviewboard.kde.org/r/101037/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dawit
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110407/c2eb1c4c/attachment.htm>