Review Request: KIO Proxy Support Overhaul Part II: KProtocolManager & KIO::Scheduler

Dawit Alemayehu adawit at kde.org
Wed Apr 6 05:31:35 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101037/
-----------------------------------------------------------

Review request for kdelibs.


Summary
-------

This the second part of a series of patches designed to improve and bring KIO's proxy support to the levels of KDE 3.5 and beyond. Unlike the first series, https://git.reviewboard.kde.org/r/100971/, these set of patches are focused on the two classes in KIO that are responsible for providing proxy information to all ioslaves, KProtocolManager and KIO::Scheduler. Here are a list of the changes contained within:

KProtocolManager:
------------------
* Add socks proxy support to KProtocolManager.
* Add functions for obtaining multiple proxy URL addresses when configured through PAC scripts.
* Add support for obtaining system proxy information on Windows and Mac platforms. [1]

KIO::Scheduler:
---------------
* Set a new meta-data, "ProxyUrls" with a list of comma separated proxy urls.[2]


[1] Please note that on Linux/Unix platforms system proxy configuration is assumed to be set through enivronment variables and has been supported since the days of KDE 2.0.
[2] The existing meta-data "UseProxy" will still be set with the first url from the list.


Diffs
-----

  kio/kio/scheduler.cpp d657bf6 
  kio/DESIGN.metadata f5dfcd1 
  kio/kio/job_p.h 620e487 
  kio/kio/kprotocolmanager.h 814e2f2 
  kio/kio/kprotocolmanager.cpp 56e1942 

Diff: http://git.reviewboard.kde.org/r/101037/diff


Testing
-------


Thanks,

Dawit

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110406/1bee1b0f/attachment.htm>


More information about the kde-core-devel mailing list