Review Request: introduce the class Configuration Compile Configuration for kconfig_compiler

[Aaron Seigo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5479/#review7890
-----------------------------------------------------------


just a couple of minor comments


/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp
<http://svn.reviewboard.kde.org/r/5479/#comment8141>

    should be const QString &



/trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp
<http://svn.reviewboard.kde.org/r/5479/#comment8139>

    perhaps consider adding the codegenFilename param to the ctor, as the class isn't particularly useful without it :)
    
    this would render these two lines into just:
    
    CfgConfig cfg(codegenFilename);
    
    also, please watch the whitespace usage to keep this file as consistent as possible (e.g. spaces around the '=')


- Aaron


On 2010-09-29 17:28:11, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5479/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 17:28:11)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Just create the class CfgConfig, grouping all the configuration items in one place.
> Also, use an instance where any of the configuration values is needed.
> 
> Next patch: make independent the input parser and the output to c++ language.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdecore/kconfig_compiler/kconfig_compiler.cpp 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5479/diff
> 
> 
> Testing
> -------
> 
> tested time ago in cygwin.
> tested few minutes ago recompiling akregator.
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100929/990d6ba3/attachment.htm>