Review Request: Minor GUI change to rename/overwrite dialog window

[David Jarvie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/#review7869
-----------------------------------------------------------


I'm sceptical about replacing the warnings "This action will overwrite '%1' with an older/same age/newer file...". The relative ages of the files can be a useful factor in deciding whether or not to continue with the overwrite operation. IMO it's important to keep the warning about replacing the file with an older one, since that's the most likely to highlight to the user that the overwrite is not what was intended.

- David


On 2010-09-27 23:05:59, Steven Sroka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5443/
> -----------------------------------------------------------
> 
> (Updated 2010-09-27 23:05:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
> 
> This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.
> 
> 
> This addresses bug 238942.
>     https://bugs.kde.org/show_bug.cgi?id=238942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201 
> 
> Diff: http://svn.reviewboard.kde.org/r/5443/diff
> 
> 
> Testing
> -------
> 
> Correctly Compiled.
> "Eye ball'ed" Code.
> Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
> Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
> 
> (I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)
> 
> 
> Thanks,
> 
> Steven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100929/b6030c6e/attachment.htm>