Review Request: Minor GUI change to rename/overwrite dialog window

[Parker Coates]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/#review7864
-----------------------------------------------------------


Could we have before and after screenshots?

- Parker


On 2010-09-27 23:05:59, Steven Sroka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5443/
> -----------------------------------------------------------
> 
> (Updated 2010-09-27 23:05:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
> 
> This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.
> 
> 
> This addresses bug 238942.
>     https://bugs.kde.org/show_bug.cgi?id=238942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1179201 
> 
> Diff: http://svn.reviewboard.kde.org/r/5443/diff
> 
> 
> Testing
> -------
> 
> Correctly Compiled.
> "Eye ball'ed" Code.
> Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
> Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
> 
> (I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)
> 
> 
> Thanks,
> 
> Steven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100928/75514352/attachment.htm>