[WebKit-devel] KParts::TextExtension

[Dawit A]

On Sun, Sep 26, 2010 at 4:07 AM, Urs Wolfer <uwolfer at kde.org> wrote:
> On Friday 24 September 2010 21:40:26 David Faure wrote:
>> I just committed a KParts::TextExtension, so that kparts plugins
>> (babelfish, kttsplugin etc.) or web browsers themselves can get
>> information such as: bool hasSelection(), QString selectedText(Format
>> format), QString
>> completeText(Format format) and signal selectionChanged(),
>> in a web-browser-engine independent way.
>>
>> The api is below for post-commit review :-)
>> Now is a good time to ask for more virtual methods in there.
>>
>> The reason I'm posting this here, is to let other kpart authors know about
>> it. For instance if katepart provides this extension then babelfish and
>> text-to- speech would also work with it (e.g. in konqueror).
>>
>> I'll commit http://www.davidfaure.fr/2010/kttsplugin.diff (kdebase) on
>> Monday, it leads to a pretty nice cleanup of that code.
>>
>> Question: when can I commit extragear/base/konq-plugins/babelfish, i.e.
>> when can it depend on kdelibs trunk?
>
> I think using #ifdef's there would be the save way.
>
>> Question for webkit-devel: when can I commit the use of TextExtension to
>> extragear/base/kwebkitpart?
>
> As Dawit already told: we try to support the last stable KDE release, so
> please use #ifdef's here as well.

At some we are going to have to start branching versions that get
packaged up and released like you did a short while back. It is
neither sane nor sustainable to use #ifdef to support different KDE
releases in the long term...