Review Request: Attica will not be found if installed under /usr/local/
neundorf at kde.org
Sun Sep 26 10:38:22 BST 2010
On Thursday 23 September 2010, Alexander Neundorf wrote:
> On Thursday 23 September 2010, Guy Maurel wrote:
> > On Wednesday 22 September 2010 21:28:35 you wrote:
> > > We have FindPackageHandleStandardArgs.cmake in kdelibs from current
> > > cmake, please have a look at its documentation.
> > > It should be possible to remove the whole version checking chunk and
> > > just do
> > This really the *better* way.
> > Could it be possible to move (all) the cmake files to this method?
> > It will be an improvment for all of us!
> Of course, it just needs somebody to do it :-)
> I'd be very happy if you help with this and start posting patches for
> review to kde-buildsystem (it is important not to break source
Done for kdelibs/cmake/modules/FindSharedMimeInfo.cmake.
All results (i.e. the executable and the version string are also cached
properly, no need for the if(...FOUND) donothing ELSE() hacks.
You can now also do
Looking forward to patches for other Find-modules :-)
More information about the kde-core-devel