Review Request: Allow to get and set max size of pixmap cache from KImageCache

Michael Pyne mpyne at kde.org
Sat Sep 25 23:06:03 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5377/#review7803
-----------------------------------------------------------

Ship it!


OK, the most recent changes look good.

- Michael


On 2010-09-25 21:15:09, Manuel Mommertz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5377/
> -----------------------------------------------------------
> 
> (Updated 2010-09-25 21:15:09)
> 
> 
> Review request for kdelibs and Michael Pyne.
> 
> 
> Summary
> -------
> 
> Set a reasonable maximum size for the pixmap cache and allow to get and set this size.
> 
> For now the pixmap cache gets a maximum size of 10% from the shared data cache on disk. Is this a good value or should it be something different?
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/util/kimagecache.h 1178685 
>   trunk/KDE/kdelibs/kdeui/util/kimagecache.cpp 1178685 
> 
> Diff: http://svn.reviewboard.kde.org/r/5377/diff
> 
> 
> Testing
> -------
> 
> I use 4.5 branche with this patch applied for daily work. No Problems so far.
> 
> 
> Thanks,
> 
> Manuel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100925/7a72cd91/attachment.htm>


More information about the kde-core-devel mailing list